Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for sqlite3_interrupt #545

Open
troygibb opened this issue Feb 27, 2023 · 1 comment
Open

[Feature Request] Support for sqlite3_interrupt #545

troygibb opened this issue Feb 27, 2023 · 1 comment

Comments

@troygibb
Copy link

Hey sql.js maintainers! Thanks so much for this great software, we've been getting great milage out of it!

It sounds like it's possible to add sqlite3_interrupt support based on your discussion in #461, it just hasn't been prioritized. We've implemented the suggested workaround of killing and re-instantiating the worker, but obviously it would be a lot more performant if we surgically interrupted queries.

Is this feature on your radar? Any idea of how much work it would involve? Thanks in advance!

@kaizhu256
Copy link
Member

  • unlikely to be on radar soon.
  • sqlite3_interrupt() requires opening a secondary database-connection in a secondary thread to interrupt the first thread
  • web-workers are single-threaded -- there's no easy way to [asynchronously] open a secondary database-connection to it and call sqlite3_interrupt().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants