Skip to content
This repository has been archived by the owner on Sep 8, 2018. It is now read-only.

Unable to find time zone names America/St Barthelemy #49

Open
monove opened this issue Feb 3, 2016 · 16 comments
Open

Unable to find time zone names America/St Barthelemy #49

monove opened this issue Feb 3, 2016 · 16 comments

Comments

@monove
Copy link

monove commented Feb 3, 2016

Any ideas?

@mattjohnsonpint
Copy link

You need an underscore where you have a space.

@monove
Copy link
Author

monove commented Feb 8, 2016

Uncaught Error: Unable to find time zone named America/St_Barthelemy
(WallTime 0.2.0)

@jgable
Copy link
Contributor

jgable commented Feb 8, 2016

I think this is because the America/St_Barthelemy rule is really a Link to America/Guadeloupe. I don't think I ever implemented link situations.

@robmadden
Copy link

Whatever @jgable says is right, so just listen to him.

@mattjohnsonpint
Copy link

Yep, that would do it as well. I'd recommend supporting links. Zones occasionally move to links upon new versions of tzdb.

@getaaron
Copy link

getaaron commented Feb 8, 2016

I agree with @robmadden

@monove
Copy link
Author

monove commented Feb 8, 2016

But how would I get a link mapping?

@geedew
Copy link
Contributor

geedew commented Feb 9, 2016

@robmadden ...
@robmadden

@az-tock
Copy link

az-tock commented Feb 9, 2016

+1 @getaaron

@jgable
Copy link
Contributor

jgable commented Feb 9, 2016

Why do I feel like I'm being hazed? You know what the real hazing was, when I had to write this monstrosity for handling timezones in the first place.

Shouldn't people be using http://momentjs.com/timezone/ by now? They really do a much better job at this and they have like a million tests.

Man, and this library is written in CoffeeScript, talk about nobody else being able to maintain it. I'm stuck with this thing for life.

@monove
Copy link
Author

monove commented Feb 9, 2016

"Moment Timezone has no data for America/St Barthelemy"

@monove
Copy link
Author

monove commented Feb 9, 2016

never mnd that, i missed the underscore

@mattjohnsonpint
Copy link

@jgable - Despite jumping on the moment.js / moment-timezone bandwagon, I've also tried to give fair credit to alternatives like walltime (and a few others). Believe me, I considered answering this issue with "just use moment instead" - but thought you guys would frown on that. Would you prefer we consider walltime discontinued and move along? Just askin'. :)

@jgable
Copy link
Contributor

jgable commented Feb 10, 2016

I think it would be relatively clear from looking at the commits/pulse graph that this library isn't being maintained. I'm no longer at Sprout Social so I can't speak for them, but I'd be +1 to putting a notice in the readme.

@soung3
Copy link
Contributor

soung3 commented Feb 10, 2016

We're actually actively in the process of converting over to Moment.js at Sprout Social. We'll update the README to state the end of support, unless someone else wants to carry the torch.

@mattjohnsonpint
Copy link

Thanks for clarifying. If I can do anything to ease the transition, please let me know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

8 participants