Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session override causes error for non tenanted routes #56

Closed
ollieread opened this issue Nov 17, 2024 · 1 comment · Fixed by #58
Closed

Session override causes error for non tenanted routes #56

ollieread opened this issue Nov 17, 2024 · 1 comment · Fixed by #58
Assignees
Labels
status: accepted The issue has been accepted/acknowledged and is being actioned or will be type: fix Fix for a bug or other issue
Milestone

Comments

@ollieread
Copy link
Member

When creating non-tenanted routes while the session override is enabled, all requests to those routes will give a tenancy missing or tenant missing error.

The fix currently is to disable the session override.

Ultimately the override needs to be updated to only kick in when within the tenant context.

Note

Make sure to mention in the docs about implicit service overrides.

Bug reported by @Diddyy

@ollieread ollieread added status: accepted The issue has been accepted/acknowledged and is being actioned or will be type: fix Fix for a bug or other issue labels Nov 17, 2024
@ollieread ollieread added this to the V1 Release milestone Nov 17, 2024
@ollieread ollieread self-assigned this Nov 17, 2024
@ollieread
Copy link
Member Author

This is specifically with the database driver for the session

@github-project-automation github-project-automation bot moved this from In progress to Done in Sprout Development Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted The issue has been accepted/acknowledged and is being actioned or will be type: fix Fix for a bug or other issue
Projects
Status: Done
1 participant