test: Complete the test suite #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollieread
added
type: test
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=======================================
Coverage ? 53.31%
Complexity ? 473
=======================================
Files ? 64
Lines ? 1341
Branches ? 0
=======================================
Hits ? 715
Misses ? 626
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Remove the manual booting of service overrides from the SproutServiceProvider::boot() method and add to the Application::booted() lifecycle event
* chore: Add core Sprout settings repository * refactor: Replace cookie value overrides with usage of settings repository * refactor: Implement settings repository for overrides * refactor: Add helper methods for settings * fix: Fix database override setting
# Conflicts: # src/Concerns/HandlesServiceOverrides.php # src/Concerns/OverridesCookieSettings.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses #36 by completing the test suite, as well as refactoring to separate out unit and feature tests.