Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to conditionaly use the captcha? #13

Open
loicteixeira opened this issue Feb 7, 2018 · 3 comments
Open

How to conditionaly use the captcha? #13

loicteixeira opened this issue Feb 7, 2018 · 3 comments
Labels

Comments

@loicteixeira
Copy link
Contributor

Made With Wagtail uses wagtail-django-recaptcha but does not use WagtailCaptchaFormBuilder directly and rather defines it's own form builder which conditionally inherit from it or Wagtail base FormBuilder depending on whether recaptcha has been configured for the current environment (e.g. don't use the captcha on dev).

While I can understand the intend, I'm not too keen on that kind of things but maybe that's just me. I'd be curious to hear from others how you feel about it?

Should this package conditionally add the captcha field on the same conditions as the utility linked above or stay away from such consideration?

@loicteixeira
Copy link
Contributor Author

Pinging @BertrandBordage since you seem to use the package.

@BertrandBordage
Copy link
Contributor

Simply add a condition to this line:

fields[self.CAPTCHA_FIELD_NAME] = ReCaptchaField(label='')

@loicteixeira
Copy link
Contributor Author

Thanks @BertrandBordage.

Indeed the fix is simple but I was mostly concerned whether this would be considered related to the user's application logic and by the fact it will silently not insert the field if the application has a misconfiguration.

I'll leave the issue open for a little bit before taking action in case anybody else wants to jump in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants