Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature engineering example #10

Open
boc410 opened this issue May 2, 2024 · 0 comments
Open

Feature engineering example #10

boc410 opened this issue May 2, 2024 · 0 comments

Comments

@boc410
Copy link

boc410 commented May 2, 2024

This is a very minor issue with the wording used in the "Domain Knowledge Features" section of the Feature Engineering notebook.

I believe the sentence should indicate there is an anomaly where some memberships expire before the transactions date (instead of after). The following code appears to apply a filter to include only data where memberships expire after the transaction date.

From the notebook:
There is one slight anomaly with the transactions where some membership expire dates are after the transactions date, so we will filter those out.

#Filter anomalies
trans = trans[trans['membership_expire_date'] > trans['transaction_date']]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant