Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only get Neutral Spirit on Browsers besides chrome #72

Closed
zmbube opened this issue Mar 29, 2017 · 6 comments
Closed

Only get Neutral Spirit on Browsers besides chrome #72

zmbube opened this issue Mar 29, 2017 · 6 comments
Labels

Comments

@zmbube
Copy link
Contributor

zmbube commented Mar 29, 2017

The spirit view always resolves to displaying the neutral spirit on all browsers except for chrome.

@zmbube zmbube added the bug label Mar 29, 2017
@zmbube
Copy link
Contributor Author

zmbube commented Mar 29, 2017

I believe this is related to an issue with paper-checkbox in the checklist view. The issue is mentioned here PolymerElements/paper-checkbox#170

@zmbube
Copy link
Contributor Author

zmbube commented Mar 29, 2017

@doctor-g after following your suggestions and fiddling around with it a bit i discovered the problem is coming from the event.target call. In firefox the compiled page has sub parts to the checkbox like the container and the label and returns these rather than the whole checkbox where the index and checked properties are.
screen shot 2017-03-29 at 1 43 44 pm

@doctor-g
Copy link
Contributor

@zmbube It's a little unclear to me from what you said above. Can you clarify, what is event.target returning in Chrome and Firefox? This line is returning something different from each?

Looking at the code, I see that the local variable item is never used, so it can be cut.

@zmbube
Copy link
Contributor Author

zmbube commented Mar 29, 2017

In Firefox and Safari even is returning the div checkboxContainer or checkboxLabel from the picture above depending on if you click the text or the box. Chrome returns the paper-checkbox itself no matter where you click.

@doctor-g
Copy link
Contributor

Aha, I see. I put a debugger call in the onCheckboxTap method, and then went into the console and evaluated event.target in each. Chrome gives you the paper-checkbox that has a valid checked property; Firefox does not.

@doctor-g
Copy link
Contributor

@zmbube Try using event.currentTarget instead and see if that helps.

It would also be great to have a unit test to reproduce this in fewer steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants