Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift restriction on empty JpaEntityGraph attributes #3684

Closed
wants to merge 3 commits into from

Conversation

christophstrobl
Copy link
Member

Closes: #3682

This commit removes a check preventing EntityGraphs from being created for JpaEntityGraphs without attributes.
An EntityGraph without attributes is valid. Therefore it is not possible to determine if a given JpaEntityGraph is a dynamic one just by looking at the attributes alone.
@mp911de mp911de changed the title Lift restriction on empty JpaEntityGraph attributes. Lift restriction on empty JpaEntityGraph attributes Nov 21, 2024
@mp911de mp911de added the type: bug A general bug label Nov 21, 2024
@mp911de mp911de added this to the 3.4.1 (2024.1.1) milestone Nov 21, 2024
@mp911de mp911de changed the title Lift restriction on empty JpaEntityGraph attributes Lift restriction on empty JpaEntityGraph attributes Nov 21, 2024
mp911de pushed a commit that referenced this pull request Nov 21, 2024
This commit removes a check preventing EntityGraphs from being created for JpaEntityGraphs without attributes.

Original pull request: #3684
Closes #3682
mp911de pushed a commit that referenced this pull request Nov 21, 2024
An EntityGraph without attributes is valid. Therefore it is not possible to determine if a given JpaEntityGraph is a dynamic one just by looking at the attributes alone.

Original pull request: #3684
See #3682
mp911de added a commit that referenced this pull request Nov 21, 2024
Remove JPA 2.1 guards as we require JPA 3.x. Refine API to reduce nullability.

Original pull request: #3684
See #3682
mp911de pushed a commit that referenced this pull request Nov 21, 2024
This commit removes a check preventing EntityGraphs from being created for JpaEntityGraphs without attributes.

Original pull request: #3684
Closes #3682
mp911de pushed a commit that referenced this pull request Nov 21, 2024
An EntityGraph without attributes is valid. Therefore it is not possible to determine if a given JpaEntityGraph is a dynamic one just by looking at the attributes alone.

Original pull request: #3684
See #3682
mp911de added a commit that referenced this pull request Nov 21, 2024
Remove JPA 2.1 guards as we require JPA 3.x. Refine API to reduce nullability.

Original pull request: #3684
See #3682
@mp911de
Copy link
Member

mp911de commented Nov 21, 2024

That's merged, polished, and backported now.

@mp911de mp911de closed this Nov 21, 2024
@mp911de mp911de deleted the issue/3682 branch November 21, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty attributePaths on @EntityGraph produces exception
2 participants