Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all EntityManager variables to entityManager in SimpleJpaRepository. #3120

Closed
wants to merge 2 commits into from

Conversation

jeomxon
Copy link
Contributor

@jeomxon jeomxon commented Aug 18, 2023

In the current SimpleJpaRepository, most of the variable names for EntityManager were em.
Changing the variable name of this constructor parameter to em also looks good.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 18, 2023
@quaff
Copy link
Contributor

quaff commented Aug 21, 2023

I think the name entityManager is better than em.

@jeomxon
Copy link
Contributor Author

jeomxon commented Aug 21, 2023

@quaff
But In SimpleJpaRepository, most of the variable names for EntityManager were em.
Is it good to change all em to entityManager?

@quaff
Copy link
Contributor

quaff commented Aug 21, 2023

@quaff But In SimpleJpaRepository, most of the variable names for EntityManager were em. Is it good to change all em to entityManager?

It's safe to rename private variable, and I prefer to rename all em to entityManager.

@jeomxon
Copy link
Contributor Author

jeomxon commented Aug 21, 2023

@quaff
I rename all EntityManager variables to entityManager in SimpleJpaRepository.
Thank you :)

@jeomxon jeomxon changed the title Rename the variable of the constructor parameter in the SimpleJpaRepository. Rename all EntityManager variables to entityManager in SimpleJpaRepository. Aug 21, 2023
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 24, 2023
@mp911de mp911de self-assigned this Aug 24, 2023
@gregturn gregturn added this to the 3.2 M3 (2023.1.0) milestone Sep 8, 2023
@gregturn gregturn self-assigned this Sep 8, 2023
gregturn pushed a commit that referenced this pull request Sep 8, 2023
gregturn pushed a commit that referenced this pull request Sep 8, 2023
gregturn pushed a commit that referenced this pull request Sep 8, 2023
@gregturn
Copy link
Contributor

gregturn commented Sep 8, 2023

Thanks @jeomxon! Merged to main, backported to 3.1.x and 3.0.x.

@gregturn gregturn closed this Sep 8, 2023
gregturn added a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants