Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Authorization: Bearer #24

Open
artembilan opened this issue Nov 8, 2024 · 0 comments
Open

Add support for Authorization: Bearer #24

artembilan opened this issue Nov 8, 2024 · 0 comments

Comments

@artembilan
Copy link

Right now this service expects from us Authorization: Basic, which is not so bad from CURL perspective - just -u "username:token", but that still requires from us to know a GH user behind provided token.
The GithubAuthenticationManager can be adjusted to just rely on that provided GH token and then probably call respective GH API: https://docs.github.com/en/rest/users/users?apiVersion=2022-11-28#get-the-authenticated-user.
This would let our project-api clients to avoid extra gh api /user --jq '.login' call or hard code username into our clients or require it alongside with the token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant