Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Repositories in MavenResolverDependencyManagementVersionResolver configurable #1067

Open
sbyrx opened this issue Mar 10, 2020 · 1 comment

Comments

@sbyrx
Copy link

sbyrx commented Mar 10, 2020

MavenResolverDependencyManagementVersionResolver contains hard-coded URLs for Maven Central and the Spring Snapshot and Milestone repositories.

At my company we have an internal Nexus repository where our custom Spring Boot starters are published. I'd like to be able to configure it as a resolver and pull versions from there.

I'd be happy to contribute a PR making the list of repositories configurable in YAML.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 10, 2020
@snicoll
Copy link
Contributor

snicoll commented Mar 17, 2020

@sbyron15 thanks for the report. We need first to change the API of MavenResolverDependencyManagementVersionResolver. Perhaps a builder style approach where the repositories (and the Path location can be configured). Once we have that in place, we can consider making it configurable although I'd argue it's a secondary step. We already have the notion of repositories in the metadata so I wonder if registering those would be an option.

Are you still willing to work on a PR?

@snicoll snicoll added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 17, 2020
@snicoll snicoll changed the title Repositories in MavenResolverDependencyManagementVersionResolver are not configurable Make Repositories in MavenResolverDependencyManagementVersionResolver configurable Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants