Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show_unapproved_ratings setting not behaving properly #84

Open
FineLineAutomation opened this issue Jan 25, 2014 · 3 comments
Open

show_unapproved_ratings setting not behaving properly #84

FineLineAutomation opened this issue Jan 25, 2014 · 3 comments

Comments

@FineLineAutomation
Copy link

2 things are happening when show_unapproved_ratings is checked:

  • Unapproved reviews do not count toward the compiled rating at the top. This is funky when there is one unapproved review showing and the top rating is blank and says "Based on 0 Reviews"
  • When there are no reviews, Instead of displaying the "There are no reviews" line it displays a blank rating that says (Based On 0 Reviews)
@radar
Copy link
Contributor

radar commented Jan 31, 2014

Hi @FineLineAutomation, could you please look at submitting a patch for this issue?

@FineLineAutomation
Copy link
Author

@radar, I will probably be submitting an all encompassing patch for this and Issue #85 together for 2-0-stable that pulls in all the spec refactoring work done on master/2-1-stable. Give me a few days and I'll have something together.

@radar
Copy link
Contributor

radar commented Jan 31, 2014

Excellent, thanks Nate :)

On Sat, Feb 1, 2014 at 1:03 AM, Nathan Lowrie [email protected]:

@radar https://github.com/radar, I will probably be submitting an all
encompassing patch for this and Issue #85https://github.com/spree/spree_reviews/pull/85together for 2-0-stable that pulls in all the spec refactoring work done on
master/2-1-stable. Give me a few days and I'll have something together.

Reply to this email directly or view it on GitHubhttps://github.com//issues/84#issuecomment-33795952
.

Ryan Bigg
Community Manager
Spree Commerce, Inc.

Join us in New York City for SpreeConf 2014 February
26th and 27th. Learn more http://www.spreeconf.com/

Use the code Spreeconf_RB to get 33% off!

http://www.spreeconf.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants