Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prawn locked at 1.0.0? #82

Open
chriscarpenter12 opened this issue Apr 15, 2015 · 3 comments
Open

Prawn locked at 1.0.0? #82

chriscarpenter12 opened this issue Apr 15, 2015 · 3 comments

Comments

@chriscarpenter12
Copy link

Why is prawn locked at ~> 1.0.0?

2.0.1 seems to be the latest stable version.
https://rubygems.org/gems/prawn/versions/2.0.1

Bundler could not find compatible versions for gem "prawn":
  In Gemfile:
    spree_print_invoice (>= 0) ruby depends on
      prawn (~> 1.0.0) ruby

    prawn (~> 2.0.1) ruby
@alepore
Copy link
Member

alepore commented Apr 15, 2015

👍 we should try to switch to a recent prawn, or at least to the last 1.x version...
this comes from f0d38c4

@tvdeyen
Copy link
Contributor

tvdeyen commented Apr 15, 2015

Yes. Will try to have a look tomorrow.

@lucaferri
Copy link

I tried to update the prawn version on the 3-0-stable branch and it seams to work flawlessly.

I simply updated prawn to version 1.3 and I had to add prawn-table gem (version 0.2.1) because prawn dropped support for tables after version 1.0.
No other changes seams to be required.

The alternative could be to edit the template to replace tables with some other elements, so there will be no need to use the prawn-table gem too.

In the next days I will try to go forward and update prawn to version 2.0.1.

lucaferri pushed a commit to lucaferri/spree_print_invoice that referenced this issue Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants