Can't find a way to limit sliders lines

[pyladune]

Hi,

The product description appears nearly fully inside the slider while it would make sens only first lines or main concerns appear there.

Is there a way to manage that easily ?

Thanks

Seb

[radar]

Hi Seb,

Can you please show us a screenshot of this happening?

Thanks!

On Sun, Jan 5, 2014 at 9:18 PM, Seb [email protected] wrote:

Hi,
The product description appears nearly fully inside the slider while it would make sens only first lines or main concerns appear there.

Is there a way to manage that easily ?
Thanks

Seb

Reply to this email directly or view it on GitHub:
#85

[pyladune]

It may be more clear if on slider appear just 1 or 2 sentences, not the whole thing of the product description
I tried to override _slider.html.erb, that works except that i'm stucked with hmtl, as once truncated html tags are not considered anymore. also The truncate_html gem (htmlentities) seems generates errors while used beside spree

Thanks

[radar]

The truncatehtml gem (htmlentities) seems generates errors while used beside spree

Could you please include these errors? Just saying it "generates errors" is not a useful description for me, because it doesn't give me anything to go on. It could be that you're calling the method wrong or... I don't know. Please provide more information. truncate_html is the way to do what you want to do.

[pyladune]

Comprehensive list of steps to reproduce the issue.
Fill in a large description for a product. Include eépty lines. On slider it will all appear in one block
I reproduced that on the demo store .
the product is . http://majestic-store-5639.spree.mx/products/apache-baseball-jersey
Look at in inside thre slider : http://majestic-store-5639.spree.mx/products

What you're expecting to happen compared with what's actually happening.
To have only the first paragrah desplay on the slider, otherwise it not really readable and too much info

The version of Spree and the version of Rails.
spree is edge one
Rails is 4.1.3
ruby is 2.1.0

Gemfile

source 'https://rubygems.org'

Bundle edge Rails instead: gem 'rails', github: 'rails/rails'

gem 'rails', '4.0.2'

Use sqlite3 as the database for Active Record

gem 'sqlite3'
#gem 'mysql2'

Use SCSS for stylesheets

gem 'sass-rails', '~> 4.0.0'

Use Uglifier as compressor for JavaScript assets

gem 'uglifier', '>= 1.3.0'

Use CoffeeScript for .js.coffee assets and views

gem 'coffee-rails', '~> 4.0.0'

See https://github.com/sstephenson/execjs#readme for more supported runtimes

gem 'therubyracer', platforms: :ruby

Use jquery as the JavaScript library

gem 'jquery-rails'

Turbolinks makes following links in your web application faster. Read more: https://github.com/rails/turbolinks

gem 'turbolinks'

Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder

gem 'jbuilder', '~> 1.2'

gem 'spree', github: 'spree/spree'
gem 'spree_auth_devise', github: 'spree/spree_auth_devise'
gem 'spree_fancy', :github => 'spree/spree_fancy'
#gem 'spree_skrill', :git => 'git://github.com/spree/spree_skrill.git'
gem 'spree_print_invoice' , :git => 'git://github.com/spree/spree_print_invoice.git'
gem "nokogiri"
gem "htmlentities"
gem 'spree_gateway', github: 'spree/spree_gateway'

group :doc do

bundle exec rake doc:rails generates the API under doc/api.

gem 'sdoc', require: false
end

Trace
Showing /home/seb/Documents/Sites/storetest/app/views/spree/home/_slider.html.erb where line #12 raised:

undefined method `truncate_html' for #<#Class:0x007f480ae03f68:0x007f48057e47e0>
Extracted source (around line #12):
9
10
11
12
13
14
15

         <div class="product-info">
           <h1 class="product-title"><%= product.name %></h1>
           <div class="product-description">
             <%= truncate_html product.description.to_s , :length => 15 %>
           </div>
           <div class="product-order-form">
             <%= form_for :order, :url => populate_orders_path do |f| %>

Trace of template inclusion: /home/seb/.rbenv/versions/2.1.0-rc1/lib/ruby/gems/2.1.0/bundler/gems/spree_fancy-d679fd8bb382/app/views/spree/home/index.html.erb

Rails.root: /home/seb/Documents/Sites/storetest

Application Trace | Framework Trace | Full Trace
/home/seb/.rbenv/versions/2.1.0-rc1/lib/ruby/gems/2.1.0/bundler/gems/spree-b95e0034555e/core/app/helpers/spree/base_helper.rb:149:in method_missing' app/views/spree/home/_slider.html.erb:12:inblock in _fe9266dbed8a4cc98a704d7214e68a3d'
activerecord (4.0.2) lib/active_record/relation/delegation.rb:13:in each' activerecord (4.0.2) lib/active_record/relation/delegation.rb:13:ineach'
app/views/spree/home/_slider.html.erb:4:in _fe9266dbed8a4cc98a704d7214e68a3d' actionpack (4.0.2) lib/action_view/template.rb:143:inblock in render'
activesupport (4.0.2) lib/active_support/notifications.rb:161:in instrument' actionpack (4.0.2) lib/action_view/template.rb:141:inrender'
deface (1.0.0) lib/deface/action_view_extensions.rb:41:in render' actionpack (4.0.2) lib/action_view/renderer/partial_renderer.rb:306:inrender_partial'
actionpack (4.0.2) lib/action_view/renderer/partial_renderer.rb:279:in block in render' actionpack (4.0.2) lib/action_view/renderer/abstract_renderer.rb:38:inblock in instrument'
activesupport (4.0.2) lib/active_support/notifications.rb:159:in block in instrument' activesupport (4.0.2) lib/active_support/notifications/instrumenter.rb:20:ininstrument'
activesupport (4.0.2) lib/active_support/notifications.rb:159:in instrument' actionpack (4.0.2) lib/action_view/renderer/abstract_renderer.rb:38:ininstrument'
actionpack (4.0.2) lib/action_view/renderer/partial_renderer.rb:278:in render' actionpack (4.0.2) lib/action_view/renderer/renderer.rb:47:inrender_partial'
actionpack (4.0.2) lib/action_view/helpers/rendering_helper.rb:27:in render' /home/seb/.rbenv/versions/2.1.0-rc1/lib/ruby/gems/2.1.0/bundler/gems/spree_fancy-d679fd8bb382/app/views/spree/home/index.html.erb:2:inblock in _93358cccd797901c3f5245eb36baa2f3'
actionpack (4.0.2) lib/action_view/helpers/capture_helper.rb:38:in block in capture' actionpack (4.0.2) lib/action_view/helpers/capture_helper.rb:200:inwith_output_buffer'
actionpack (4.0.2) lib/action_view/helpers/capture_helper.rb:38:in capture' actionpack (4.0.2) lib/action_view/helpers/capture_helper.rb:152:incontent_for'
/home/seb/.rbenv/versions/2.1.0-rc1/lib/ruby/gems/2.1.0/bundler/gems/spree_fancy-d679fd8bb382/app/views/spree/home/index.html.erb:1:in _93358cccd797901c3f5245eb36baa2f3' actionpack (4.0.2) lib/action_view/template.rb:143:inblock in render'
activesupport (4.0.2) lib/active_support/notifications.rb:161:in instrument' actionpack (4.0.2) lib/action_view/template.rb:141:inrender'
deface (1.0.0) lib/deface/action_view_extensions.rb:41:in render' actionpack (4.0.2) lib/action_view/renderer/template_renderer.rb:49:inblock (2 levels) in render_template'
actionpack (4.0.2) lib/action_view/renderer/abstract_renderer.rb:38:in block in instrument' activesupport (4.0.2) lib/active_support/notifications.rb:159:inblock in instrument'
activesupport (4.0.2) lib/active_support/notifications/instrumenter.rb:20:in instrument' activesupport (4.0.2) lib/active_support/notifications.rb:159:ininstrument'
actionpack (4.0.2) lib/action_view/renderer/abstract_renderer.rb:38:in instrument' actionpack (4.0.2) lib/action_view/renderer/template_renderer.rb:48:inblock in render_template'
actionpack (4.0.2) lib/action_view/renderer/template_renderer.rb:56:in render_with_layout' actionpack (4.0.2) lib/action_view/renderer/template_renderer.rb:47:inrender_template'
actionpack (4.0.2) lib/action_view/renderer/template_renderer.rb:17:in render' actionpack (4.0.2) lib/action_view/renderer/renderer.rb:42:inrender_template'
actionpack (4.0.2) lib/action_view/renderer/renderer.rb:23:in render' actionpack (4.0.2) lib/abstract_controller/rendering.rb:127:in_render_template'
actionpack (4.0.2) lib/action_controller/metal/streaming.rb:219:in _render_template' actionpack (4.0.2) lib/abstract_controller/rendering.rb:120:inrender_to_body'
actionpack (4.0.2) lib/action_controller/metal/rendering.rb:33:in render_to_body' actionpack (4.0.2) lib/action_controller/metal/renderers.rb:26:inrender_to_body'
actionpack (4.0.2) lib/abstract_controller/rendering.rb:97:in render' actionpack (4.0.2) lib/action_controller/metal/rendering.rb:16:inrender'
actionpack (4.0.2) lib/action_controller/metal/instrumentation.rb:41:in block (2 levels) in render' activesupport (4.0.2) lib/active_support/core_ext/benchmark.rb:12:inblock in ms'
/home/seb/.rbenv/versions/2.1.0-rc1/lib/ruby/2.1.0/benchmark.rb:294:in realtime' activesupport (4.0.2) lib/active_support/core_ext/benchmark.rb:12:inms'
actionpack (4.0.2) lib/action_controller/metal/instrumentation.rb:41:in block in render' actionpack (4.0.2) lib/action_controller/metal/instrumentation.rb:84:incleanup_view_runtime'
activerecord (4.0.2) lib/active_record/railties/controller_runtime.rb:25:in cleanup_view_runtime' actionpack (4.0.2) lib/action_controller/metal/instrumentation.rb:40:inrender'
actionpack (4.0.2) lib/action_controller/metal/implicit_render.rb:10:in default_render' actionpack (4.0.2) lib/action_controller/metal/implicit_render.rb:5:insend_action'
actionpack (4.0.2) lib/abstract_controller/base.rb:189:in process_action' actionpack (4.0.2) lib/action_controller/metal/rendering.rb:10:inprocess_action'
actionpack (4.0.2) lib/abstract_controller/callbacks.rb:18:in block in process_action' activesupport (4.0.2) lib/active_support/callbacks.rb:453:in_run__544688204793959545__process_action__callbacks'
activesupport (4.0.2) lib/active_support/callbacks.rb:80:in run_callbacks' actionpack (4.0.2) lib/abstract_controller/callbacks.rb:17:inprocess_action'
actionpack (4.0.2) lib/action_controller/metal/rescue.rb:29:in process_action' actionpack (4.0.2) lib/action_controller/metal/instrumentation.rb:31:inblock in process_action'
activesupport (4.0.2) lib/active_support/notifications.rb:159:in block in instrument' activesupport (4.0.2) lib/active_support/notifications/instrumenter.rb:20:ininstrument'
activesupport (4.0.2) lib/active_support/notifications.rb:159:in instrument' actionpack (4.0.2) lib/action_controller/metal/instrumentation.rb:30:inprocess_action'
actionpack (4.0.2) lib/action_controller/metal/params_wrapper.rb:245:in process_action' activerecord (4.0.2) lib/active_record/railties/controller_runtime.rb:18:inprocess_action'
actionpack (4.0.2) lib/abstract_controller/base.rb:136:in process' actionpack (4.0.2) lib/abstract_controller/rendering.rb:44:inprocess'
actionpack (4.0.2) lib/action_controller/metal.rb:195:in dispatch' actionpack (4.0.2) lib/action_controller/metal/rack_delegation.rb:13:indispatch'
actionpack (4.0.2) lib/action_controller/metal.rb:231:in block in action' actionpack (4.0.2) lib/action_dispatch/routing/route_set.rb:80:incall'
actionpack (4.0.2) lib/action_dispatch/routing/route_set.rb:80:in dispatch' actionpack (4.0.2) lib/action_dispatch/routing/route_set.rb:48:incall'
actionpack (4.0.2) lib/action_dispatch/journey/router.rb:71:in block in call' actionpack (4.0.2) lib/action_dispatch/journey/router.rb:59:ineach'
actionpack (4.0.2) lib/action_dispatch/journey/router.rb:59:in call' actionpack (4.0.2) lib/action_dispatch/routing/route_set.rb:680:incall'
railties (4.0.2) lib/rails/engine.rb:511:in call' railties (4.0.2) lib/rails/railtie/configurable.rb:30:inmethod_missing'
actionpack (4.0.2) lib/action_dispatch/journey/router.rb:71:in block in call' actionpack (4.0.2) lib/action_dispatch/journey/router.rb:59:ineach'
actionpack (4.0.2) lib/action_dispatch/journey/router.rb:59:in call' actionpack (4.0.2) lib/action_dispatch/routing/route_set.rb:680:incall'
warden (1.2.3) lib/warden/manager.rb:35:in block in call' warden (1.2.3) lib/warden/manager.rb:34:incatch'
warden (1.2.3) lib/warden/manager.rb:34:in call' rack (1.5.2) lib/rack/etag.rb:23:incall'
rack (1.5.2) lib/rack/conditionalget.rb:25:in call' rack (1.5.2) lib/rack/head.rb:11:incall'
actionpack (4.0.2) lib/action_dispatch/middleware/params_parser.rb:27:in call' actionpack (4.0.2) lib/action_dispatch/middleware/flash.rb:241:incall'
rack (1.5.2) lib/rack/session/abstract/id.rb:225:in context' rack (1.5.2) lib/rack/session/abstract/id.rb:220:incall'
actionpack (4.0.2) lib/action_dispatch/middleware/cookies.rb:486:in call' activerecord (4.0.2) lib/active_record/query_cache.rb:36:incall'
activerecord (4.0.2) lib/active_record/connection_adapters/abstract/connection_pool.rb:626:in call' activerecord (4.0.2) lib/active_record/migration.rb:369:incall'
actionpack (4.0.2) lib/action_dispatch/middleware/callbacks.rb:29:in block in call' activesupport (4.0.2) lib/active_support/callbacks.rb:373:in_run__950471987698164716__call__callbacks'
activesupport (4.0.2) lib/active_support/callbacks.rb:80:in run_callbacks' actionpack (4.0.2) lib/action_dispatch/middleware/callbacks.rb:27:incall'
actionpack (4.0.2) lib/action_dispatch/middleware/reloader.rb:64:in call' actionpack (4.0.2) lib/action_dispatch/middleware/remote_ip.rb:76:incall'
actionpack (4.0.2) lib/action_dispatch/middleware/debug_exceptions.rb:17:in call' actionpack (4.0.2) lib/action_dispatch/middleware/show_exceptions.rb:30:incall'
railties (4.0.2) lib/rails/rack/logger.rb:38:in call_app' railties (4.0.2) lib/rails/rack/logger.rb:20:inblock in call'
activesupport (4.0.2) lib/active_support/tagged_logging.rb:67:in block in tagged' activesupport (4.0.2) lib/active_support/tagged_logging.rb:25:intagged'
activesupport (4.0.2) lib/active_support/tagged_logging.rb:67:in tagged' railties (4.0.2) lib/rails/rack/logger.rb:20:incall'
actionpack (4.0.2) lib/action_dispatch/middleware/request_id.rb:21:in call' rack (1.5.2) lib/rack/methodoverride.rb:21:incall'
rack (1.5.2) lib/rack/runtime.rb:17:in call' activesupport (4.0.2) lib/active_support/cache/strategy/local_cache.rb:83:incall'
rack (1.5.2) lib/rack/lock.rb:17:in call' actionpack (4.0.2) lib/action_dispatch/middleware/static.rb:64:incall'
rack (1.5.2) lib/rack/sendfile.rb:112:in call' railties (4.0.2) lib/rails/engine.rb:511:incall'
railties (4.0.2) lib/rails/application.rb:97:in call' rack (1.5.2) lib/rack/lock.rb:17:incall'
rack (1.5.2) lib/rack/content_length.rb:14:in call' rack (1.5.2) lib/rack/handler/webrick.rb:60:inservice'
/home/seb/.rbenv/versions/2.1.0-rc1/lib/ruby/2.1.0/webrick/httpserver.rb:138:in service' /home/seb/.rbenv/versions/2.1.0-rc1/lib/ruby/2.1.0/webrick/httpserver.rb:94:inrun'
/home/seb/.rbenv/versions/2.1.0-rc1/lib/ruby/2.1.0/webrick/server.rb:295:in `block in start_thread'

[pyladune]

Nothing new about that ?

Thanks