addresed requested changes

spran180 · Jul 22, 2024 · 47cbf38 · 47cbf38
1 parent 302b1cc
commit 47cbf38
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/internal_modules/roc_core/mov_histogram.h b/src/internal_modules/roc_core/mov_histogram.h
@@ -64,16 +64,15 @@ template <typename T> class MovHistogram {
             T oldest_value = ring_buffer_.front();
             ring_buffer_.pop_front();
             size_t oldest_bin_index = get_bin_index_(oldest_value);
-            if (oldest_bin_index >= 0
-                && static_cast<size_t>(oldest_bin_index) < num_bins_) {
-                bins_[static_cast<size_t>(oldest_bin_index)]--;
+            if (oldest_bin_index < num_bins_) {
+                bins_[oldest_bin_index]--;
             }
         }
 
         ring_buffer_.push_back(value);
         size_t new_bin_index = get_bin_index_(value);
-        if (new_bin_index >= 0 && static_cast<size_t>(new_bin_index) < num_bins_) {
-            bins_[static_cast<size_t>(new_bin_index)]++;
+        if (new_bin_index < num_bins_) {
+            bins_[new_bin_index]++;
         }
     }
 
@@ -85,7 +84,6 @@ template <typename T> class MovHistogram {
 private:
     //! returns the bin index for a given value
     size_t get_bin_index_(const T& value) const {
-
         T clamped_value = value;
 
         if (clamped_value < value_range_min_) {