Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEMs downloaded from GitHub App Registration Portal have empty new line #153

Open
tlawrie opened this issue Oct 17, 2023 · 2 comments
Open

PEMs downloaded from GitHub App Registration Portal have empty new line #153

tlawrie opened this issue Oct 17, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tlawrie
Copy link

tlawrie commented Oct 17, 2023

Context:
The PEMs downloaded from GitHub App Registration Portal have an empty new line after "-----END RSA PRIVATE KEY-----"

Issue
This then causes the PEM to fail the matcher check in the code
@Abhi347
Copy link
Member

Abhi347 commented May 28, 2024

Hey, just found this issue. Can you provide an example PEM file (replace the secret inside with random string first) and the error you are getting to reproduce this issue.

@Abhi347 Abhi347 added bug Something isn't working good first issue Good for newcomers labels May 28, 2024
@mdxabu
Copy link

mdxabu commented May 31, 2024

@Abhi347 can you give some explanation about this, After that, I'll start my work towards it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Abhi347 @tlawrie @mdxabu