Model mismatch with basic-pitch-ts ?

[tiborvass]

Thanks for this great project! I would like to use this python project and get the same results as on https://basicpitch.spotify.com.

I am a newbie with TensorFlow but I'm assuming the models used in the basic-pitch and basic-pitch-ts projects are not exactly the same:

• https://github.com/spotify/basic-pitch/tree/ad9ab8a65d18a1cb06dee25f45855acc4598a10a/basic_pitch/saved_models/icassp_2022/nmp
• https://github.com/spotify/basic-pitch-ts/tree/2d498f82b61c71898edf0e8dd661b99076676c8b/model

First of all: am I wrong in my assumptions ? If not, it would be great to have both projects use the same model (despite being in a different format).

I myself tried using both tensorflowjs_converter and tfjs_graph_converter but none worked or possibly I did something wrong.

Thanks for any help!

[drubinstein]

The model used in basic-pitch-ts is based on running the tfjs converter on the one in this repo. The test data is actually from running inference with the scripts here so they should be equivalent.

You may see some differences in the website based on the slider values used.