Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator Helm Chart v3.3.0 fails at 1st launch #654

Closed
paretl opened this issue Aug 29, 2023 · 15 comments · May be fixed by #655
Closed

Operator Helm Chart v3.3.0 fails at 1st launch #654

paretl opened this issue Aug 29, 2023 · 15 comments · May be fixed by #655
Labels
stale

Comments

@paretl
Copy link

paretl commented Aug 29, 2023

Expected behaviour

Launch the Operator Helm chart v3.3.0 (latest one today)

Actual behaviour

It fails fast and the error is:

STDERR:
Error: failed to install CRD crds/databases.spotahome.com_redisfailovers.yaml: error parsing : error converting YAML to JSON: yaml: line 4: did not find expected node content

When digging a little bit, I saw that the crds/databases.spotahome.com_redisfailovers.yaml file has these lines:

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  annotations:
    {{- with .Values.crds.annotations }}
    {{- toYaml . | nindent 4 }}
    {{- end }}
    controller-gen.kubebuilder.io/version: (devel)
  creationTimestamp: null
  name: redisfailovers.databases.spotahome.com

So I guess that the go template part in annotations is not expected here

Steps to reproduce the behavior

⚠️ Be sure that you have no current RedisFailover CRD installed. Otherwise, there is no failure. I usually remove the entire release to be sure that everything is removed.

To reproduce, launch the redis-operator chart with v3.3.0.

Environment

How are the pieces configured?

  • Redis Operator version: v1.3.0-rc1 but it fails for any versions
  • Kubernetes version: v1.27

Logs

There is no more details about this error in the logs with the --debug flag.
@paretl
Copy link
Author

paretl commented Aug 29, 2023 •
edited
Loading

Ok I saw that the change is already included in the PR #651

I have created a sub-PR with only this fix to be able to use the latest version of the chart without waiting the approval/test of the other changes: #655

@paretl paretl mentioned this issue Aug 29, 2023
Open
@zeddit
Copy link

zeddit commented Aug 29, 2023

I am facing the same issue, should I wait for the upstream helm chart to be updated. thanks

@ebuildy
Copy link
Contributor

ebuildy commented Aug 30, 2023

we need such annotations for argocd, I have opened #656 to harcode it

@haliliceylan
Copy link

In argocd, I am not able to use this chart. When the planning release time ?

@ebuildy
Copy link
Contributor

ebuildy commented Sep 15, 2023

there is a PR to fix it #656 - waiting for some approvals

@xolott
Copy link

xolott commented Sep 18, 2023

Same error, trying to deploy the operator into an AKS cluster.

@Avnshrai
Copy link

Avnshrai commented Oct 6, 2023

same error, when it is going to get fixed?
I am not able to try it for my use case because of this issue

@zeddit
Copy link

zeddit commented Oct 17, 2023

hi, any progress on this.
I am looking forward to the feature of exposing redis master IP directly.
great thanks.

@sylvainOL
Copy link

Hello, any news?

@Avnshrai
Copy link

don't know what is taking too long to merge a PR, I can see just by removing those annotations operator is working fine, and in values.yaml there is a wrong image tag, need to provide v1.3.0-rc instead of v1.3.0 as I can see there is no image with v1.3.0
Screenshot 2023-10-27 at 12 15 59 PM

@lenaxia
Copy link

lenaxia commented Nov 14, 2023

For anyone interested, I got 3.3.0 to install using this method:

  1. Download a local copy of the CRDs to your HelmRelease as crds.yaml
  2. Fix the annotation in the crds.yaml
  3. Disable CRD installation in your HR by setting spec.values.crds.enabled: false
  4. install the CRDs via kustomize, by adding crds.yaml to your kustomization.yaml file

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 45 days with no activity.

@github-actions github-actions bot added the stale label Dec 30, 2023
@github-actions GitHub Actions
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2024
@pando85
Copy link

pando85 commented Jan 13, 2024

Re open it, please.

1 similar comment
@rotemjac
Copy link

Re open it, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix go template annotations of CRD in the helm chart paretl/redis-operator
10 participants
@ebuildy @pando85 @xolott @lenaxia @rotemjac @paretl @zeddit @Avnshrai @haliliceylan @sylvainOL