Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate txn_id check doesn't filter out flagged IPNs #119

Closed
rakiru opened this issue Nov 8, 2015 · 0 comments
Closed

Duplicate txn_id check doesn't filter out flagged IPNs #119

rakiru opened this issue Nov 8, 2015 · 0 comments

Comments

@rakiru
Copy link

rakiru commented Nov 8, 2015

If an IPN fails for some reason[1] and is flagged, any future IPN attempts will fail with a "Duplicate txn_id" error, even though we have received no previous successful IPN. I think all this needs is for duplicate_txn_id to filter out flagged IPNs before checking for previous ones, but I'd need to check since I'm not entirely familiar with the internals yet. I'll send a PR at some point if no-one else gets around to looking at it before I do.

[1] At least, if it fails while doing the verification postback
Mentioned in #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants