Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder-level import #16

Open
spluxx opened this issue Apr 24, 2020 · 0 comments
Open

Folder-level import #16

spluxx opened this issue Apr 24, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@spluxx
Copy link
Owner

spluxx commented Apr 24, 2020

Suggested by @DoneSpeak #13

In some projects, the protobuf files are separated into various folders - an example project structure would be

-- service1
     |- service1.proto (imports models)
-- service2
     |- service2.proto (imports models / service1)
-- core
     |- models.proto
-- 

Although the proto_path feature introduced in v0.3.2 makes it possible to build these files together, an easy way to import all .proto files in a folder is yet to be delivered.

My take on this problem is to allow selection of the root directory, which

  1. sets the proto_path to the selected path and
  2. adds all .proto files under it

It might even make sense to enforce this to be the only way to import the .proto files, and make the proto_path implicit rather than having the users pick the files one by one and type the proto_path in. But I'll have to dig into the protoc docs and make sure this doesn't block certain project structures.

@spluxx spluxx added the enhancement New feature or request label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant