Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phdigitalshadows: adding requirements.txt and building wheels #1

Open
1 of 15 tasks
splunk-soar-connectors-bot opened this issue Nov 9, 2021 · 1 comment
Open
1 of 15 tasks

Comments

@splunk-soar-connectors-bot
Copy link
Collaborator

PAPP-20799: added requirements.txt and wheels

Note:

  • I tried, unsuccessfully, to find the correct dsapi in pypi and GitHub, so I could replace that folder with a wheel.
  • I don't see anything obviously risky with keeping that folder as-is

Testing:

  • workflow actions for this PR are not green, but I think the failure is acceptable:
    • The failure is: JSON config param ds_api_key should probably be of data_type password or file
    • The author seems to have been thoughtful enough to use "data_type": "password" for ds_api_secret_key. It doesn’t feel like it was an accident to use "data_type": "string" for ds_api_key right above it
  • built and installed a tarball in this SOAR cloud instance (version 5.1.0.68293)
  • also installed tarball in this SOAR on-prem instance (version 5.1.0.68966)
    confirmed that /opt/phantom/apps/digitalshadows_8cebdfd7-afe9-48eb-b840-2d98f860ed79/dependencies/ contains at least all the items from wheels

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The readme.html and readme.md have been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.
  • Limit your pull request to one application and submit multiple pull requests if necessary.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Release Notes (REQUIRED)

  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)


Thanks for contributing!

@yashwanth-metron
Copy link

yashwanth-metron commented Dec 12, 2022

Config param ds_api_key data_type is assigned String intentionally,
do we need to make any changes?

aparekh-crest pushed a commit that referenced this issue Dec 23, 2022
fixes for post breach record review and get intel ioc actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants