Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error message is logged every second when startup of split client fails #334

Open
tom-mi opened this issue Aug 31, 2022 · 3 comments
Open

Comments

@tom-mi
Copy link

tom-mi commented Aug 31, 2022

We are currently adding split.io to one of our backend services, but we don't have the API key yet, so we added a dummy value.
Upon startup of the container, we observed a huge amount of error logs like this:

RefreshableSplitFetcher failed: Problem fetching splitChanges: Could not retrieve splitChanges; http return code 400

This log message is repeated every second (causing quota issues with our logging solution).
We assume that the problematic place in the code is in SyncManagerImp.start(), where upon receiving any exception, there is only a sleep of 1000ms and then a retry is performed.

The expected behavior would be to have some kind of exponential backoff in place, so that ever if Split.io is down or returns an error, our services can start up without producing tons of error logs.

Thx for having a look!

@agustinona
Copy link

Hi @tom-mi let me consult this with our engineering team and I'll get back to you as soon as possible.

In the meantime, may I suggest you use "localhost" as your dummy key? This will cause the SDK to initialize in the locahost mode (see: https://help.split.io/hc/en-us/articles/360020405151-Java-SDK#localhost-mode), where it will not attempt to connect to Split and will not log any of those error messages.

@nmayorsplit
Copy link
Contributor

Hi @tom-mi,
we fixed another issue that it's related to this one in the Java SDK version 4.4.6. Can you try the new version? please.
I'll be waiting for a response if you still have the same problem.

Thank you.

Nadia

@tom-mi
Copy link
Author

tom-mi commented Sep 14, 2022

Hi @nmayorsplit ,
thanks for the update. The situation has improved, as now the log message is only printed every 10 seconds instead of every second. I'd prefer an even longer max wait time, especially as in our case the error was a client error which will never recover by itself.
However, for our purposes the current value of 10s would probably already be sufficently high to prevent hitting our log quotas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants