From 82b9775aee7c427e83398d93883c94e8321d072c Mon Sep 17 00:00:00 2001 From: Andrew Duffy Date: Wed, 7 Aug 2024 23:41:22 -0400 Subject: [PATCH] revert --- encodings/alp/src/array.rs | 2 +- encodings/alp/src/compress.rs | 3 +-- encodings/byte-bool/src/compute/mod.rs | 4 ++-- encodings/byte-bool/src/lib.rs | 2 +- encodings/datetime-parts/src/compress.rs | 3 +-- encodings/datetime-parts/src/compute.rs | 8 +++----- encodings/dict/benches/dict_compress.rs | 3 +-- encodings/dict/src/compress.rs | 6 ++---- encodings/dict/src/compute.rs | 3 +-- encodings/dict/src/dict.rs | 2 +- encodings/fastlanes/benches/bitpacking_take.rs | 3 +-- encodings/fastlanes/src/bitpacking/compress.rs | 3 +-- .../fastlanes/src/bitpacking/compute/search_sorted.rs | 5 ++--- encodings/fastlanes/src/bitpacking/compute/slice.rs | 2 +- encodings/fastlanes/src/bitpacking/compute/take.rs | 7 ++----- encodings/fastlanes/src/bitpacking/mod.rs | 4 ++-- encodings/fastlanes/src/delta/compress.rs | 2 +- encodings/fastlanes/src/for/compress.rs | 3 +-- encodings/fastlanes/src/for/compute.rs | 2 +- encodings/roaring/src/boolean/compress.rs | 2 +- encodings/roaring/src/boolean/mod.rs | 4 ++-- encodings/roaring/src/integer/compress.rs | 2 +- encodings/roaring/src/integer/mod.rs | 4 ++-- encodings/runend-bool/src/array.rs | 2 +- encodings/runend-bool/src/compress.rs | 5 ++--- encodings/runend-bool/src/compute.rs | 2 +- encodings/runend/src/compress.rs | 4 ++-- encodings/runend/src/compute.rs | 4 ++-- encodings/runend/src/runend.rs | 2 +- encodings/zigzag/src/compress.rs | 2 +- encodings/zigzag/src/zigzag.rs | 2 +- 31 files changed, 43 insertions(+), 59 deletions(-) diff --git a/encodings/alp/src/array.rs b/encodings/alp/src/array.rs index 267a57bd5a..cfc648ba51 100644 --- a/encodings/alp/src/array.rs +++ b/encodings/alp/src/array.rs @@ -1,7 +1,7 @@ use std::fmt::Debug; use serde::{Deserialize, Serialize}; -use vortex::array::primitive::PrimitiveArray; +use vortex::array::PrimitiveArray; use vortex::stats::ArrayStatisticsCompute; use vortex::validity::{ArrayValidity, LogicalValidity}; use vortex::variants::{ArrayVariants, PrimitiveArrayTrait}; diff --git a/encodings/alp/src/compress.rs b/encodings/alp/src/compress.rs index bda2cae993..c9265d2e58 100644 --- a/encodings/alp/src/compress.rs +++ b/encodings/alp/src/compress.rs @@ -1,6 +1,5 @@ use itertools::Itertools; -use vortex::array::primitive::PrimitiveArray; -use vortex::array::sparse::{Sparse, SparseArray}; +use vortex::array::{PrimitiveArray, Sparse, SparseArray}; use vortex::validity::Validity; use vortex::{Array, ArrayDType, ArrayDef, IntoArray, IntoArrayVariant}; use vortex_dtype::{NativePType, PType}; diff --git a/encodings/byte-bool/src/compute/mod.rs b/encodings/byte-bool/src/compute/mod.rs index c5e33a0434..5afd2c1caa 100644 --- a/encodings/byte-bool/src/compute/mod.rs +++ b/encodings/byte-bool/src/compute/mod.rs @@ -5,7 +5,7 @@ use num_traits::AsPrimitive; use vortex::compute::unary::{FillForwardFn, ScalarAtFn}; use vortex::compute::{ArrayCompute, CompareFn, SliceFn, TakeFn}; use vortex::validity::{ArrayValidity, Validity}; -use vortex::{Array, ArrayDType, IntoArray, IntoArrayVariant, ToArrayData}; +use vortex::{Array, ArrayDType, IntoArray, IntoArrayVariant}; use vortex_dtype::{match_each_integer_ptype, Nullability}; use vortex_error::VortexResult; use vortex_expr::Operator; @@ -136,7 +136,7 @@ impl CompareFn for ByteBoolArray { impl FillForwardFn for ByteBoolArray { fn fill_forward(&self) -> VortexResult { if self.dtype().nullability() == Nullability::NonNullable { - return Ok(self.to_array_data().into_array()); + return Ok(self.clone().into()); } let validity = self.logical_validity().to_null_buffer()?.unwrap(); diff --git a/encodings/byte-bool/src/lib.rs b/encodings/byte-bool/src/lib.rs index 63a1cebc01..05e6c6e8b2 100644 --- a/encodings/byte-bool/src/lib.rs +++ b/encodings/byte-bool/src/lib.rs @@ -3,7 +3,7 @@ use std::mem::ManuallyDrop; use arrow_buffer::BooleanBuffer; use serde::{Deserialize, Serialize}; -use vortex::array::bool::BoolArray; +use vortex::array::BoolArray; use vortex::stats::StatsSet; use vortex::validity::{ArrayValidity, LogicalValidity, Validity, ValidityMetadata}; use vortex::variants::{ArrayVariants, BoolArrayTrait}; diff --git a/encodings/datetime-parts/src/compress.rs b/encodings/datetime-parts/src/compress.rs index d06b4c7b7e..d582624ec2 100644 --- a/encodings/datetime-parts/src/compress.rs +++ b/encodings/datetime-parts/src/compress.rs @@ -1,5 +1,4 @@ -use vortex::array::datetime::{TemporalArray, TimeUnit}; -use vortex::array::primitive::PrimitiveArray; +use vortex::array::{PrimitiveArray, TemporalArray, TimeUnit}; use vortex::compute::unary::try_cast; use vortex::{Array, IntoArray, IntoArrayVariant}; use vortex_dtype::PType; diff --git a/encodings/datetime-parts/src/compute.rs b/encodings/datetime-parts/src/compute.rs index ad5a8d2153..48ce586527 100644 --- a/encodings/datetime-parts/src/compute.rs +++ b/encodings/datetime-parts/src/compute.rs @@ -1,6 +1,5 @@ -use vortex::array::datetime::temporal::TemporalMetadata; -use vortex::array::datetime::{TemporalArray, TimeUnit}; -use vortex::array::primitive::PrimitiveArray; +use vortex::array::temporal::TemporalMetadata; +use vortex::array::{PrimitiveArray, TemporalArray, TimeUnit}; use vortex::compute::unary::{scalar_at, ScalarAtFn}; use vortex::compute::{slice, take, ArrayCompute, SliceFn, TakeFn}; use vortex::validity::ArrayValidity; @@ -120,8 +119,7 @@ pub fn decode_to_temporal(array: &DateTimePartsArray) -> VortexResult