From 603142b287ca529ebecc6d395584e562de639413 Mon Sep 17 00:00:00 2001 From: Joe Isaacs Date: Thu, 19 Dec 2024 15:40:58 +0000 Subject: [PATCH] oops --- vortex-array/src/array/constant/compute/boolean.rs | 2 ++ vortex-array/src/compute/boolean.rs | 6 ++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/vortex-array/src/array/constant/compute/boolean.rs b/vortex-array/src/array/constant/compute/boolean.rs index c93b37305b..656465dfd2 100644 --- a/vortex-array/src/array/constant/compute/boolean.rs +++ b/vortex-array/src/array/constant/compute/boolean.rs @@ -107,6 +107,8 @@ mod test { #[case(BoolArray::from_iter([Some(true), Some(false), Some(true), Some(false)].into_iter()).into_array(), ConstantArray::new(true, 4).into_array())] fn test_and(#[case] lhs: ArrayData, #[case] rhs: ArrayData) { + let rr = and(&lhs, &rhs); + println!("{:?}", rr); let r = and(&lhs, &rhs).unwrap().into_bool().unwrap().into_array(); let v0 = scalar_at(&r, 0).unwrap().as_bool().value(); diff --git a/vortex-array/src/compute/boolean.rs b/vortex-array/src/compute/boolean.rs index 6f7a25399f..fc03187bce 100644 --- a/vortex-array/src/compute/boolean.rs +++ b/vortex-array/src/compute/boolean.rs @@ -169,13 +169,11 @@ pub(crate) fn arrow_boolean( let nullable = lhs.dtype().is_nullable() || rhs.dtype().is_nullable(); let lhs = Canonical::Bool(lhs.into_bool()?) - // TODO: fixme - .into_arrow(&DataType::Int32)? + .into_arrow(&DataType::Boolean)? .as_boolean() .clone(); let rhs = Canonical::Bool(rhs.into_bool()?) - // TODO: fixme - .into_arrow(&DataType::Int32)? + .into_arrow(&DataType::Boolean)? .as_boolean() .clone();