Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spiral/tokenzier] Adds tokenizer:info console command #963

Merged
merged 7 commits into from
Aug 14, 2023

Conversation

butschster
Copy link
Member

@butschster butschster commented Aug 10, 2023

image

Note
This PR also fixes system bootloaders initialization. The will init only after Environment object creation and binding to the container. It will allow developers to use env variables in System bootloaders.

…rs init only after Environment is bound to the container
@butschster butschster modified the milestones: 3.9, 3.8 Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 42.59% and project coverage change: -0.16% ⚠️

Comparison is base (e2b43f3) 83.83% compared to head (e1b8438) 83.68%.

❗ Current head e1b8438 differs from pull request most recent head 5d56380. Consider uploading reports for the commit 5d56380 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #963      +/-   ##
============================================
- Coverage     83.83%   83.68%   -0.16%     
- Complexity     5988     5998      +10     
============================================
  Files           786      787       +1     
  Lines         16898    16931      +33     
============================================
+ Hits          14167    14169       +2     
- Misses         2731     2762      +31     
Files Changed Coverage Δ
src/Framework/Command/Tokenizer/InfoCommand.php 0.00% <0.00%> (ø)
src/Tokenizer/src/Config/TokenizerConfig.php 92.30% <60.00%> (-7.70%) ⬇️
src/Boot/src/AbstractKernel.php 97.22% <100.00%> (-2.78%) ⬇️
...ork/Bootloader/Attributes/AttributesBootloader.php 90.32% <100.00%> (+0.32%) ⬆️
...c/Tokenizer/src/Bootloader/TokenizerBootloader.php 100.00% <100.00%> (ø)
...zer/src/Bootloader/TokenizerListenerBootloader.php 95.34% <100.00%> (-0.31%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz
Copy link
Member

@butschster butschster merged commit d7a1a9d into master Aug 14, 2023
7 checks passed
@butschster butschster deleted the feature/916 branch August 14, 2023 15:05
@butschster butschster changed the title Changes behavior for loading system bootloaders. [spiral/tokenzier] Adds tokenizer:info console command Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2 participants