Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to restart database containers on startup #128

Open
idoqo opened this issue Jun 19, 2022 · 5 comments
Open

Provide option to restart database containers on startup #128

idoqo opened this issue Jun 19, 2022 · 5 comments
Labels
hacktoberfest Hacktoberfest issues

Comments

@idoqo
Copy link
Collaborator

idoqo commented Jun 19, 2022

Say a user restarts the docker service (or reboots the server), and the database containers created by spinup continue existing but are not restarted.

This means after such a restart, all the databases shown on the dashboard are actually not active/running (unless the user starts them manually).

Maybe we can provide an option to automatically start all databases in the spinup_services network on startup? We can even make this a default behavior and give users the option to start afresh.

@amitech
Copy link

amitech commented Jul 22, 2022

@idoqo is someone working on it?
I would like to work on it.

@idoqo
Copy link
Collaborator Author

idoqo commented Jul 22, 2022

Sure, go ahead @amitech, let us know if you need some help along the way.

Also if it helps, we have some mechanism for restarting containers here https://github.com/spinup-host/spinup/blob/main/internal/monitor/monitor.go#L87-L106

@viggy28
Copy link
Contributor

viggy28 commented Jul 23, 2022

Good catch on the issue @idoqo

Curious, any other container-based service handle it?

@idoqo
Copy link
Collaborator Author

idoqo commented Jul 23, 2022

Curious, any other container-based service handle it?

I don't know of any but I could check. my main issue was that we show all of them on the dashboard, so it makes sense to make sure they are running.

@amitech
Copy link

amitech commented Oct 7, 2022

Sorry for keeping it stale, I will start working on it.

@idoqo idoqo added the hacktoberfest Hacktoberfest issues label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest issues
Projects
None yet
Development

No branches or pull requests

3 participants