-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document SPIN_EXPERIMENTAL #39
Comments
I would say no, for the time being - we don't really want folks who aren't actively working on SpinKube projects to actively interact with those commands until we're closer to figuring out the long term UX goals of various plugins. By documenting them we somewhat signup to actively supporting them (and being careful about breaking changes). |
If we did document this flag, we could deliberately only document it in one place. Thinking the Spin Plugin k8s CLI Reference might be the best place. We can differentiate running with SPIN_EXPERIMENTAL=1 in a separate section. This will allow us to remove those commands if they don't become part of the stable set of commands. |
IMO I think it's fine to document the flag without documenting the commands associated with that flag. For example:
From that description, it is very clear that we are not signing up to support these features and that breaking changes are clearly part of the CLI experience. We could go one step further and print a warning message to STDERR when these experimental features are being used. @endocrimes does that allay your earlier concerns here, or do you still think this is not something we should document? I do share the same concerns because of how experiemental CLI feature support went with Helm 3 development. However I think that was a matter of the maintainers (including myself) not having enough of a backbone to say "no" to the client when they wanted us to address compatibility concerns with experimental features. |
There are a number of CLI commands hidden to the user.
Normal output:
with
SPIN_EXPERIMENTAL=1
:Do we want to document this flag? Why or why not?
The text was updated successfully, but these errors were encountered: