Skip to content

Commit

Permalink
Update changelog and ADMM default inner its
Browse files Browse the repository at this point in the history
  • Loading branch information
spinicist committed Aug 25, 2023
1 parent 0740143 commit 2c3abb2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
## Changelog

# v0.12

- A much improved ADMM implementation, including the residual balancing scheme from Wohlberg 2017. This shows much more robust convergence behaviour. The default number of inner iterations is now only 1, giving improved speed.
- Implemented a version of PDHG that supports multiple regularizers. However, I prefer the improved ADMM implementation.
- Implemented the NDFT (Non-uniform Discrete Fourier Transform). This is incredibly slow compared to the NUFFT, but revealed some small innacuracies in the NUFFT implementation. These have now been fixed.

# v0.11

- Fixed many bugs that crept into v0.10.
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/admm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ int main_admm(args::Subparser &parser)

args::ValueFlag<std::string> pre(parser, "P", "Pre-conditioner (none/kspace/filename)", {"pre"}, "kspace");
args::ValueFlag<float> preBias(parser, "BIAS", "Pre-conditioner Bias (1)", {"pre-bias", 'b'}, 1.f);
args::ValueFlag<Index> inner_its(parser, "ITS", "Max inner iterations (2)", {"max-its"}, 2);
args::ValueFlag<Index> inner_its(parser, "ITS", "Max inner iterations (1)", {"max-its"}, 1);
args::ValueFlag<float> atol(parser, "A", "Tolerance on A", {"atol"}, 1.e-6f);
args::ValueFlag<float> btol(parser, "B", "Tolerance on b", {"btol"}, 1.e-6f);
args::ValueFlag<float> ctol(parser, "C", "Tolerance on cond(A)", {"ctol"}, 1.e-6f);
Expand Down

0 comments on commit 2c3abb2

Please sign in to comment.