Handle KeyErrors more gracefully if user marks FILES_REG as a qc_fail.yml
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the last task from the loop is always used, regardless of whether it actually has missing_files_labels (and regardless of whether it's actually in suffix_dict.keys()).
mguaypaq
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Thanks for the fix! The code makes sense, it seems to work on the example from the course slides (I tried it manually on my laptop).
…er `if task.startswith('FILES')'` check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script now skips unsupported tasks. For example, for the following config file:
The script now prints warning and skips
FILES_REG:Resolves: #71