Skip to content
This repository has been archived by the owner on Dec 24, 2023. It is now read-only.

Add engineering process #4

Open
jenstroeger opened this issue Apr 4, 2022 · 10 comments
Open

Add engineering process #4

jenstroeger opened this issue Apr 4, 2022 · 10 comments

Comments

@jenstroeger
Copy link

Based on the python-package-template repo I think it would make sense to bring over some of the engineering and automation into this repo: pylint and black at least.

Given the number of issues we’re opening we should also replace the examples/javascript folder with proper pytest?

@SilverRainZ
Copy link
Member

Agree. I can not run examples/javascript locally due to the old dependency.

@SilverRainZ
Copy link
Member

Do you have time to work on this? I am fixing #2 and then #1.

@jenstroeger
Copy link
Author

I’ll schedule it for Tuesday. Also have another engineer who will pick up some work now.

@jenstroeger
Copy link
Author

@lecram you’re familiar with the template already. I’ll try to take a stab this weekend, and will ping you if not.

@SilverRainZ let’s start with an empty pytest folder and add unit tests as we go. This PR, I think, should be concerned with putting things into place instead of adding tests?

@SilverRainZ
Copy link
Member

I think we should need at least one test to show pytest actually works.

We can test against the changes we made, such as #5 and #6.

@SilverRainZ
Copy link
Member

Ping @jenstroeger

@jenstroeger
Copy link
Author

Ugh my apologies, it’s been very busy the past few weeks. We’re currently fixing an issue in our Py package template after which we’ll have a good baseline to merge into this repo. Are you ok waiting a week or so?

@SilverRainZ
Copy link
Member

No problem, just a reminder.

@jenstroeger
Copy link
Author

jenstroeger commented Sep 17, 2022

@SilverRainZ let’s perhaps do this in several steps:

  1. replace legacy setup.py with the recommended pyproject.toml; then
  2. add support for git hooks and use pre-commit to do add a few simple hooks (lint, flake, upgrade, see more); then
  3. change and clean up testing; then
  4. expand on the Community files; then
  5. add a few useful Github Actions (see examples).

We can adjust the Makefile as we move forward, and add more flexibility to it (see example).

Considering that Sphinx itself requires at least Python 3.6, I think the same should apply here. The metadata classifiers seem outdated

'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',

and the Makefile seems to expect Python 3. This can be fixed as part of step 1. above.

@SilverRainZ
Copy link
Member

@jenstroeger That sounds good :D

I am quite busy recently so maybe can't help :'(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants