Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle cropped DB Stats log dumps #46

Open
udi-speedb opened this issue Oct 21, 2023 · 0 comments
Open

Gracefully handle cropped DB Stats log dumps #46

udi-speedb opened this issue Oct 21, 2023 · 0 comments
Assignees

Comments

@udi-speedb
Copy link
Contributor

udi-speedb commented Oct 21, 2023

We've seen many cases in which the DB stats section in the log was cropped. This usually occurs when there are many cf-s. In that case, the log entry is sizeable and may be cropped at any point.
The result is that the log parser processes text that is malformed. There have been multiple cases where it has crashed due to that (assertions) and we've had to fix them each time they were discovered.
Being robust in face of such events should be manifested by the parser globally. However, these are common in DB Stats.

The purpose is to review the code, add applicable unit tests, and being able to gracefully discard the applicable text lines from the malformed DB Stats text.

@udi-speedb udi-speedb self-assigned this Oct 21, 2023
@udi-speedb udi-speedb changed the title Mka Gracefully handle cropped DB Stats log dumps Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant