-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the user to specify the baseline log file #12
Comments
@Yuval-Ariel - Please update the description above and add motivation / use case for this feature request. Thanks |
i've updated the description. The expected behavior regarding comparing a baseline LOG file which has multiple cfs is indeed problematic. |
@Yuval-Ariel - For example, if we wanted to compare a parsed Speedb log to a RocksDB baseline log that we chose (assuming this is desireable), it will just compare the default cf-s and ignore all of the other cf-s in the parsed log. What are the use cases that make this issue needed? |
@udi-speedb , the way it currently works is also fine |
Currently the baseline log file is determined automatically by the parser, based on the version of the parsed log and the available baseline logs.
A user might be using a different baseline than what is found in the parser which they want to check against and in that case, its good to be able to supply it externally.
To implement this the following is needed:
The text was updated successfully, but these errors were encountered: