serde(skip_serializing_if=...) is not annotated as optional (?) in TypeScript definition

[Vlad-Shcherbina]

[dependencies]
serde = { version = "1.0.216", features = ["derive"] }
serde_json = "1.0.133"
specta = { version = "2.0.0-rc.20", features = ["derive"]}
specta-typescript = { version = "0.0.7" }

fn is_false(b: &bool) -> bool { !*b }

#[derive(serde::Serialize, specta::Type)]
struct MyStruct {
    #[serde(skip_serializing_if = "is_false")]
    flag: bool,
}

fn main() {
    println!("{}", specta_typescript::export::<MyStruct>(&specta_typescript::Typescript::new()).unwrap());
    println!("{}", serde_json::to_string(&MyStruct { flag: false }).unwrap());
}

I'm getting this:

export type MyStruct = { flag: boolean }
{}

Expected:

export type MyStruct = { flag?: boolean }
{}

[oscartbeaumont]

Duplicate of #233 and definitely a great idea!

Happy for a PR if you wanted to give it a shot!

[oscartbeaumont]

The most difficult part of this is that the types when serializing and deserializing become different. Specta currently doesn't have a way to express that and long term we are going to need to have that but as a stop gap solution we can just do the most restrictive of the two.