Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACLs on public topics should be literal - edgecase #56

Closed
big-andy-coates opened this issue Feb 2, 2023 · 1 comment
Closed

ACLs on public topics should be literal - edgecase #56

big-andy-coates opened this issue Feb 2, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@big-andy-coates
Copy link
Member

big-andy-coates commented Feb 2, 2023

Currently ACLs on public topics are prefixed on resource domainId + "._public". This isn't ideal, as it grants others access to topics that may not be in the spec.

E.g. given the spec contains topic <domain.id>._public.something and the cluster already contains, or someone adds later, topic <domain.id>._public.different, then anyone will be able to read that topic, even though its not managed by SpecMesh.

This is kind of an edge case, but we have all the data to be able to create exact literal ACLs, so I think we should.

Kind of related to #58. Maybe doing #58 is sufficient?

@big-andy-coates big-andy-coates added the enhancement New feature or request label Feb 2, 2023
@big-andy-coates big-andy-coates moved this to Todo in MVP OSS Feb 2, 2023
@bluemonk3y bluemonk3y changed the title ACLs on public topics should be literal ACLs on public topics should be literal - edgecase Jul 20, 2023
@bluemonk3y
Copy link
Collaborator

my only concern with this idea is the cost of ACLs on broker performance. Once the topic growth has reached a certain point, then its difficult to change back to the current approach (i.e. remove granular ACLs and back to PREFIX only mode) - without operational overheads.

@github-project-automation github-project-automation bot moved this from Todo to Done in MVP OSS Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants