Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JSON req error on disallowed empty body #1761

Merged

Commits on Oct 29, 2023

  1. Improve JSON req error on disallowed empty body

    Currently, when a request body is empty, the JSON request validator
    would parse it into None, which is later passed down to the JSON Schema
    validator. However, jsonschema's validation error message for this case
    (when nullable is false) "None is not of type 'object'" is not
    particularly friendly to either the API user, nor the website developer.
    
    This change adds a specific check before the None value is passed to
    jsonschema to emit a better error message directly.
    
    I also added some drive-by improvements on function argument typing
    since _validate in validators don't seem to expect receiving None, but
    _parse (the result of which is passed to _validate) is totally allowed
    to return None (or anything really). This does not seem to reflect the
    logic well.
    uranusjr committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    e7a9c92 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Add test

    RobbeSneyders committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    58470e8 View commit details
    Browse the repository at this point in the history