Centralize error handling in ExceptionMiddleware #1754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was writing the documentation on exception handling, and I noticed that it was very hard to explain our current behavior.
Error handlers can be registered either on the internal Flask app (not the Starlette one) or on the Connexion app, which leads to some undefined (actually just really hard to explain) behavior. Eg.
starlette.HTTPException
errors on the Connexion app, andwerkzeug.HTTPException
errors on the Flask App, which means that registering an error handler on a status code doesn't catch all the errors with that status code.So I made the following changes:
ExceptionMiddleware
that takes into account other handlers registered on status codes.Request
andResponse
types, so users can and must now useConnexionRequest
and
ConnexionResponse
types in error handlers.ASGIRequest
class toConnexionRequest
since it is the only Request class part of the high levelConnexion interface.
We could also rename
ConnexionRequest
andConnexionResponse
to justRequest
andResponse
. Wdyt?