Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact and SoftwareArtifact are missing from v3.0.1 schema #1118

Closed
bact opened this issue Sep 11, 2024 · 4 comments
Closed

Artifact and SoftwareArtifact are missing from v3.0.1 schema #1118

bact opened this issue Sep 11, 2024 · 4 comments
Milestone

Comments

@bact
Copy link
Collaborator

bact commented Sep 11, 2024

The v3.0.1 schema is generated by shacl2code 0.0.14 (latest version, released 10 Sep 2024).

Not sure if this is an expected behaviour or not.

--

v3.0.0 schema - has Artifact and SoftwareArtifact
https://spdx.github.io/spdx-spec/v3.0.0/rdf/schema.json
v3.0.0 schema

--

v3.0.1 schema - does not has either Artifact or SoftwareArtifact
https://spdx.github.io/spdx-spec/v3.0.1/rdf/schema.json
v3.0.1 schema

--

This may related to the failure of example validation:

(error message from check-jsonschema)

Checking ./bin/../examples/jsonld/package_sbom.json
Failure resolving $ref within schema

_WrappedReferencingError: PointerToNowhere: '/$defs/Artifact' does not exist within {
...

Update: Re-run and the previous check is already passed; but got a new different failure instead:

(check-jsonschema is ok now)

Checking ./bin/../examples/jsonld/package_sbom.json
ok -- validation done
The following files were checked:
./bin/../examples/jsonld/package_sbom.json

(error message from pyshacl)

Validation Report
Conforms: False
Results (4):
Constraint Violation in MinCountConstraintComponent (http://www.w3.org/ns/shacl#MinCountConstraintComponent):
Severity: sh:Violation
Source Shape: [ sh:class ns2:CreationInfo ; sh:maxCount Literal("1", datatype=xsd:integer) ; sh:minCount Literal("1", datatype=xsd:integer) ; sh:nodeKind sh:BlankNodeOrIRI ; sh:path ns2:creationInfo ]
Focus Node: ns2:NoneElement
Result Path: ns2:creationInfo
Message: Less than 1 values on ns2:NoneElement->ns2:creationInfo
...

@bact bact added this to the 3.0.1 milestone Sep 11, 2024
@bact
Copy link
Collaborator Author

bact commented Sep 11, 2024

The cause of validation error may be about the cardinality of non-vocabulary named individuals

@goneall
Copy link
Member

goneall commented Sep 11, 2024

I believe removing the Artifact and SoftwareArtifact was intentional. From what I can tell, all abstract classes have been removed.

The current error is likely unrelated - perhaps we should open a separate issue to track.

@goneall
Copy link
Member

goneall commented Sep 11, 2024

I believe removing the Artifact and SoftwareArtifact was intentional. From what I can tell, all abstract classes have been removed.

The current error is likely unrelated - perhaps we should open a separate issue to track.

I see @bact has already opened a separate issue.

@bact
Copy link
Collaborator Author

bact commented Sep 11, 2024

I will close this one. Thanks Gary.

@bact bact closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants