-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major version: v3 #230
Major version: v3 #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I just had a quick scan through the code, as I'm not familiar with this package.
Hey @freekmurze or @AlexVanderbist, please review this new major version PR if time permits. Thanks! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work! Thank you for this
|
||
class PdfPage | ||
{ | ||
public function __construct( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A protected constructor for DTOs or VOs makes it easier to refactor or extend in the future.
public function __construct( | |
protected function __construct( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nielsvanpach Could you elaborate on this and/or is it Spatie practice to make DTO constructors protected? I'm definitely leaning towards agreement, but if you could expand a bit I'd appreciate it 👍
This PR updates the package to a new major version,
v3.0.0
.Major changes:
selectPages()
.readImage()
withpingImage()
(test suite runs ~33% faster).Breaking API Changes
There are breaking API changes from v2 to v3. I feel that these changes streamline the developer experience, enhance understanding of the functionality of the methods, and in some cases reduce cognitive overload by simplifying method names. See the modified
README.md
for a full list of the new API methods and method names.Additional Changes
php-cs-fixer
configuration and workflow was dropped in favor of Laravel Pint.