Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopening #934 for further discussion #971

Open
MrAlpha786 opened this issue Sep 19, 2024 · 1 comment
Open

Reopening #934 for further discussion #971

MrAlpha786 opened this issue Sep 19, 2024 · 1 comment

Comments

@MrAlpha786
Copy link

          Hi, I am facing the same issue and it would be nice to have an alias for nested relations, because I have to query very deeply nested relations sometimes.

I have a solution for this, what if we create a separate AllowedInclude::alias($name, $internalName), that will directly zip the two arguments. Instead of building separate path for every nested relation.

If this is okay with you, I can implement this :)

Originally posted by @MrAlpha786 in #934 (comment)

@AlexVanderbist
Copy link
Member

Hey @MrAlpha786, I'm happy to look into a better way to handle include aliases. A separate AllowedInclude method is probably the way to go at first. If the new approach works out better than the current relationship method, I'm also happy to swap both of them in a new major version. Just to be more consistent with the way people expect this feature to work. Interested to hear your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants