Using custom sorts and filters with same eager load (with)

[jeffreyvr]

When you have custom sorting and filter classes, and you need to use the with to do something (filtering / sorting) with a relation - only the last one with gets executed.

For example:

class YourCustomFilter implements Filter
{
    public function __invoke($query, $value, $property)
    {
        $query->with(['persons' => function (Builder $query) use ($property, $value) {
            $query->where($property, $value);
        }]);
    }
}

class YourCustomSort implements \Spatie\QueryBuilder\Sorts\Sort
{
    public function __invoke(Builder $query, bool $descending, string $property)
    {
        $query->with(['persons' => function ($query) use ($descending, $property) {
            $query->orderBy($property, $descending ? 'desc' : 'asc');
        }]);
    }
}

Now with some dirty hack I'm checking to see if the eager load was set earlier, grab the callback and append it to the newly set eager load.

This seems to be the default behaviour of the Laravel Querybuilder, so it's not a bug or issue of this package. But I stumbled on it within the context of using the package.

I'm interested if someone knows if I'm missing something/doing something wrong.