Use model's qualified key name for update queries (#175)

spatie · May 2, 2024 · fb8a5d0 · fb8a5d0
1 parent be0cb3f
commit fb8a5d0
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/SortableTrait.php b/src/SortableTrait.php
@@ -51,7 +51,7 @@ public static function setNewOrder($ids, int $startOrder = 1, string $primaryKey
         $orderColumnName = $model->determineOrderColumnName();
 
         if (is_null($primaryKeyColumn)) {
-            $primaryKeyColumn = $model->getKeyName();
+            $primaryKeyColumn = $model->getQualifiedKeyName();
         }
 
         if (config('eloquent-sortable.ignore_timestamps', false)) {
@@ -157,7 +157,7 @@ public function moveToStart(): static
         $this->$orderColumnName = $firstModel->$orderColumnName;
         $this->save();
 
-        $this->buildSortQuery()->where($this->getKeyName(), '!=', $this->getKey())->increment($orderColumnName);
+        $this->buildSortQuery()->where($this->getQualifiedKeyName(), '!=', $this->getKey())->increment($orderColumnName);
 
         return $this;
     }
@@ -177,7 +177,7 @@ public function moveToEnd(): static
         $this->$orderColumnName = $maxOrder;
         $this->save();
 
-        $this->buildSortQuery()->where($this->getKeyName(), '!=', $this->getKey())
+        $this->buildSortQuery()->where($this->getQualifiedKeyName(), '!=', $this->getKey())
             ->where($orderColumnName, '>', $oldOrder)
             ->decrement($orderColumnName);