Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate uv in the ci pipelines and the docs #1020

Open
sansyrox opened this issue Nov 9, 2024 · 3 comments · May be fixed by #1040
Open

integrate uv in the ci pipelines and the docs #1020

sansyrox opened this issue Nov 9, 2024 · 3 comments · May be fixed by #1040
Labels
enhancement New feature or request

Comments

@sansyrox
Copy link
Member

sansyrox commented Nov 9, 2024

integrate uv in the ci pipelines and the docs. it will make the ci faster and result in better docs

@sansyrox sansyrox added the enhancement New feature or request label Nov 9, 2024
@dave42w
Copy link
Contributor

dave42w commented Nov 12, 2024

Are you thinking we fully replace poetry with uv or that we support both? The speed that uv is being developed at is amazing.

In the 0.50.x series there is now support in uv for some things that are really helpful for us

  1. uv tree --outdated eg
 robyn v0.64.0
├── inquirerpy v0.3.4
│   ├── pfzy v0.3.4
│   └── prompt-toolkit v3.0.48
│       └── wcwidth v0.2.13
├── multiprocess v0.70.14 (latest: v0.70.17)
│   └── dill v0.3.9
├── nestd v0.3.1 (latest: v0.3.2)
├── orjson v3.9.15 (latest: v3.10.11)
├── rustimport v1.3.4 (latest: v1.5.1)
│   └── toml v0.10.2
├── uvloop v0.19.0 (latest: v0.21.0)
├── watchdog v4.0.1 (latest: v6.0.0)
└── jinja2 v3.0.1 (extra: templating) (latest: v3.1.4)
    └── markupsafe v3.0.2
  1. An experimental build system that supportd maturin see https://docs.astral.sh/uv/concepts/projects/#packaged-applications

Given the simpler support for multiple python versions maybe we should do this before supporting python 3.13?

@dave42w
Copy link
Contributor

dave42w commented Nov 12, 2024

Also it seems sensible to use uv "native" options like uv add jinja2" instead of the pip interface eg uv pip install jinja2`

@dave42w
Copy link
Contributor

dave42w commented Nov 19, 2024

This is my current mode of operation with uv

git clone [email protected]:dave42w/Robyn.git
mv Robyn my-new-branch
cd my-new-branch
uv venv
uv python pin 3.12
uv add pre-commit poetry maturin pip pytest patchelf
uv run poetry install --with dev --with test
uv run pre-commit install
uv run maturin develop
uv run test_server

in separate terminal

uv run pytest

Note that I add pip and patchelf and pytest as otherwise I can't build and get lots of test warnings

@Mr-Sunglasses Mr-Sunglasses linked a pull request Nov 19, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants