Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embed_sub to populate all data extensions #91

Open
sosey opened this issue Dec 10, 2024 · 4 comments
Open

Update embed_sub to populate all data extensions #91

sosey opened this issue Dec 10, 2024 · 4 comments

Comments

@sosey
Copy link
Member

sosey commented Dec 10, 2024

see also spacetelescope/slitlessutils#81 for the full explanation

The current form of these programs is to only embed subarrays onto the extensions relevant to the detector they belong to, but slitlessutils is expecting to loop over all detectors even if they are null.

@rosteen @larrybradley @bjkuhn

@sosey
Copy link
Member Author

sosey commented Dec 10, 2024

@pllim @rosteen does the same subarray embed routine exist in ACS for specifcally working with spectral data, I didn't see it offhand, but we should make sure it's inline with what slitlessutils is expecting, and create a ticket over there too.

@pllim
Copy link
Contributor

pllim commented Dec 10, 2024

I am not aware of any such functionality over at acstools (https://acstools.readthedocs.io/en/latest/). I also don't have ACS WBS anymore so I am going to ping @jryon and @mdlpstsci here, just in case they know of such thing elsewhere. 🙏

@mdlpstsci
Copy link
Contributor

I am not aware of this type of functionality in the ACSTOOLS.

@jryon
Copy link

jryon commented Dec 10, 2024

acstools doesn't currently have functionality for this, though I'm working on it to enable serial CTE correction of subarrays. (Serial CTE correction in CALACS can only operate on full-frames.) I have some basic code that can embed a subarray into a full-frame it for ACS/WFC, but does not mess with WCS keywords, which I'd guess are needed for slitless-related things? I'm also not sure how general it is, as I've only tested it for standard ACS/WFC subarrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants