Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write new docs page about PSF normalizations #625

Open
mperrin opened this issue Dec 14, 2022 · 5 comments
Open

Write new docs page about PSF normalizations #625

mperrin opened this issue Dec 14, 2022 · 5 comments
Assignees
Labels
Milestone

Comments

@mperrin
Copy link
Collaborator

mperrin commented Dec 14, 2022

To answer the questions which comes to the help desk about this

@mperrin mperrin added this to the Notional release 1.2 milestone Dec 14, 2022
@mperrin mperrin mentioned this issue Dec 14, 2022
2 tasks
@obi-wan76
Copy link
Collaborator

I'll use this issue to update and add new examples into the WebbPSF readthedocs. This will follow comments and bugs found during the WebbPSF workshop 2022 at the end of JWST First Science Results conference. In particular:

  1. Remove rebin option in various examples when calling calc_psf
  2. Remove calls to pupilopd that use the old format (wave cubes), e.g., https://webbpsf.readthedocs.io/en/latest/more_examples.html#make-plots-of-encircled-energy-in-psfs-at-various-wavelengths
  3. Add some examples/documents for NIRSpec, e.g., monochromatic calculation in the wavelength range, similar to the existing example for MIRI.
  4. Overall update of examples on how to use WebbPSF for specific flight observations, e.g., PSF subtraction, etc.

@BradleySappington
Copy link
Collaborator

Heads up that should be included with this:
In the documentation examples located here

miri.image_mask = 'LRS slit'
miri.pupil_mask = 'P750L'
psf = miri.calc_psf(monochromatic=6.0e-6, display=True)

Error saying “Distortion is not implemented yet for MIRI LRS mode.”

@BradleySappington
Copy link
Collaborator

#684

@mperrin mperrin modified the milestones: Release 1.2, Release 1.3 Feb 13, 2024
@mperrin mperrin added the docs label Jul 24, 2024
@mperrin
Copy link
Collaborator Author

mperrin commented Aug 5, 2024

@obi-wan76 @obi-wan76 This is a very vague issue that I wrote a while ago; can you help me remember or reconstruct what specific docs information I wanted to include as part of this?

@obi-wan76
Copy link
Collaborator

I don't remember the specifics but there has been occasional questions about the normalization options, i.e., 'first', 'last', 'exit_pupil', and what does it mean for the sum of all the pixels inside the simulated FOV. Most of the information is already there, however, I think we can be more explicit about each normalization options and what does that mean for the total intensity with an example. Same simulation with different normalization options and calculating the total sum of the simulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants