Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap for removing required downloads #210

Open
eteq opened this issue Aug 16, 2019 · 0 comments
Open

Roadmap for removing required downloads #210

eteq opened this issue Aug 16, 2019 · 0 comments

Comments

@eteq
Copy link
Contributor

eteq commented Aug 16, 2019

The goal of this issue would be for synphot itself to not have to download any data - i.e. all data part of the package - while extension packages like stsynphot would still be able to use the existing data-download machinery. The idea being that in theory synphot should have pretty minimal data requirements, but stsynphot for example by design requires quite a lot of data that shouldn't be included in the package.

Currently the data files that require downloading (which can be most easily seen in the current synphot.cfg) fill into three categories: 1) filter bandpasses 2) extinction laws 3) a Vega spectrum for vega mags. These could be dealt with via three different strategies:

  1. The filter bandpasses might be "compressed" by using tynt (https://github.com/bmorris3/tynt), or a similar approach. That ends up representing the bandpasses via Fourier coefficients and thereby requiring a lot less space. tynt seems to manage a reasonable reconstruction for ~500 filters with 150kb, so the 12 built into synphot could be reproduced with just a few KB, easy to include in the package itself. (EDIT: Also see Parameterize non-HST filter curves #38)

  2. Extinction laws could be farmed out to an external package - see Use separate package for extinction curve #132 for more. This is probably better to do anyway since it then becomes more flexible and adaptable to the future and other extinction models appear.

  3. The Vega spectrum is 270K (or 150K gzipped). Since it's very rarely likely to be updated, that seems reasonable to keep as an shipped-with-the-package data file (maybe ungzip it at install or import time or something). Then for users who really care a lot about their choice of Vega, Provide a way to give a favored Vega spectrum #209 can give them a way to use a different one.

(Prompted by a discussion @pllim and I had offline, but I think I've faithfully recorded what we discussed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants