-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase abs_separation
default value in tweakreg
#1329
Comments
Current defaults:
For absolute alignment, the settings are bad, as mentioned by @braingram, resulting in multiple sources being within the tolerance region, while |
If you want to suggest a different value, Mihai, please do. In practice we don't use relative alignment and just align to Gaia all of the time, so it is somewhat future-proofing rather than something we actually use. Practically we expect our ultimate alignment to be ~1 mas, so after tweakreg if we're doing worse than 0.1" for brightish stars something is pretty bad. Before tweakreg alignment errors of a few pixels seem plausible to me. |
=> |
The default value for
abs_separation
in romancal (0.1) matches the previous default value in jwst.However, spacetelescope/jwst#8445 increased this parameter to 1.0 with mention of the need for this to be 1.5x the tolerance (0.7). However a later PR added a slightly different check spacetelescope/jwst#8476 to verify
abs_)separation > sqrt(2) * (abs_)tolerance
.The default values in romancal could likely use some updating (and a similar check added) as I just ran into the same issue fixed by the jwst PR where running
roman_elp
on an uncal file resulted inRuntimeError: Number of output coordinates exceeded allocation
which went away when I setabs_separation
to 1.0.The failed filed were simulated images shared with me by @schlafly:
The text was updated successfully, but these errors were encountered: