Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeropoint mismatch in measuring_shapes notebook #39

Open
fjaviersanchez opened this issue Jun 24, 2024 · 0 comments
Open

Zeropoint mismatch in measuring_shapes notebook #39

fjaviersanchez opened this issue Jun 24, 2024 · 0 comments

Comments

@fjaviersanchez
Copy link
Contributor

Notebook Name:

measuring_shapes

Description

The last section of the measuring_shapes notebook performs a Sérsic fit using galsim. Unfortunately, I couldn't make the fits super robust, and I suspect there's a mismatch between the zeropoint value that I am passing to galsim and the one used internally for the simulations. Updates are needed in order to make that part of the notebook more robust. The fitting process is correct (modulo relying on the uncertainties reported by romancal), but the values of the parameters, depending on the source chosen can be pretty off.

This requires further investigation/work. Happy to tackle this before the public release, but wanted to add this issue as a cautionary note for beta testers. Thanks to @tddesjardins for confirming the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant