Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign error in fourier_shift function? #18

Open
mperrin opened this issue Feb 14, 2020 · 0 comments
Open

Sign error in fourier_shift function? #18

mperrin opened this issue Feb 14, 2020 · 0 comments
Assignees

Comments

@mperrin
Copy link
Collaborator

mperrin commented Feb 14, 2020

I've just noticed what I believe is a sign error in the fourier_shift function:

offset = fourier_shift( np.fft.fftn(image), (-yshift,xshift) )

Why is there a negative sign on the y shift but not on the x shift?

Note, this is a benign error if you avoid calling fourier_shift directly and instead invoke it through the register_to_target function (since the optimization in that function just solves for the required value with that sign error). But it's confusing if you try to directly access the fourier_shift function, or even if you just look at the output shifts as reported from register_to_target as a sanity check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants