-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TPF translator and parser #75
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature-tpf #75 +/- ##
===============================================
- Coverage 93.91% 93.30% -0.61%
===============================================
Files 35 35
Lines 1545 1689 +144
===============================================
+ Hits 1451 1576 +125
- Misses 94 113 +19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I'm a bit surprised to see this actually plot the light curve... where is that happening? Do we want that? Or do we want to force the logic through the (eventual) extraction plugin?
TODO for this PR:
Follow-up efforts (out-of-scope here):
|
It seems that the resulting cube is transposed with respect to the convention in cubeviz. Should we handle this here or elsewhere? To test, try the following with my
|
* spacetelescope#77 uses .columns which is only supported by light curves, not TPFs
bb7473e
to
c912a0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test coverage should fill in as this actually becomes usable 🤞
* Adding TPF translator and parser (#75) * TPF viewer (#81) * make use of upstream refactor to override indices in lcviz (#83) * fix creating phase-viewer when TPF is loaded (#86) * Time Selector (adapted version of cubeviz's slice) plugin (#85) * enable clone viewer for image/TPF viewer (#101) --------- Co-authored-by: Brett M. Morris <[email protected]>
Try it out with: