-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"flatten" deletes data points #142
Comments
The original points in this case have a flux of exactly zero and it appears that lightkurve's faltten results in nans for these.
I suspect this isn't actually a bug, but is actually doing as expected (although it is confusing to see points that used to be plotted no longer exist - so maybe we can at least detect this in advance and warn that it will happen). @christinahedges - is this right? Would you consider this the same as lightkurve/lightkurve#674? |
One thing that is handled by lcviz is the selected time range for plotting: if fluxes are NaNs, pressing the "home" button to zoom to all visible data is misleading. The NaNs aren't visible, so they shouldn't be in the "visible" range |
It's a good point, but the times aren't nans, only the fluxes. So, in order to exclude those points from the zoom reset logic, we'd need to filter all x-values by whether their respective y-values are nans or not. I'm honestly not sure what is the more desired behavior in this case. Any thoughts @bmorris3? |
Bug: After using flatten, some data disappears.
Expected behavior: flatten remove long-term trends but the number of data points is preserved
Steps to reproduce the bug:
The text was updated successfully, but these errors were encountered: